puncover icon indicating copy to clipboard operation
puncover copied to clipboard

Only count assembly for size when no size present

Open samfriedman opened this issue 6 years ago • 1 comments

Counting assembly bytes doesn't work properly for constant data in the .text section, which causes underreporting of sizes. The actual size reported by nm is present and accurate, so we prefer that and only count assembly bytes when nm doesn't give us a size.

samfriedman avatar Dec 04 '18 19:12 samfriedman

This is absolutely the right thing to do, thank you @samfriedman ! Unfortunately, this change won't merge cleanly anymore. Unless you are volunteering to do so, I will rebase your change on top of master and write a test for it to prevent future regressions before merging it.

HBehrens avatar Apr 23 '20 06:04 HBehrens