android-emulator-skins icon indicating copy to clipboard operation
android-emulator-skins copied to clipboard

Added Galaxy Nexus skin to repo.

Open aaronsnoswell opened this issue 14 years ago • 6 comments

Hi there! I've added a Galaxy Nexus skin to this repo, as well as updated the readme a bit. I've included a res directory where the Gimp file for the Galaxy Nexus is stored - in case we need to make changes later.

aaronsnoswell avatar Apr 04 '12 08:04 aaronsnoswell

That's great, Aaron. I will try it out and will merge your pull request if everythings runs smoothly. Are there any credits you have to give for the graphics?

HBehrens avatar Apr 04 '12 11:04 HBehrens

Sweet. No pressure :) I had a look at the DeviantArt guy who you sourced yours from, but he's since started charging for his .psd's (fair enough!) So no, I don't - the Galaxy Nexus image I based everything off was simply one of the press release ones.

aaronsnoswell avatar Apr 04 '12 11:04 aaronsnoswell

Meanwhile, I had a detailed look at your pull request. The graphics are well done, good job! It's cool to have yet another phone on the list :) I encountered some issues, though:

  • in landscape mode: the screen is not placed correctly (above case)
  • in landscape mode: highlighted state of back and menu buttons are swapped
  • the overlay is not placed correctly (too far to the bottom and right)

Can you fix this?

Also, to keep the repo as small as possible I'd suggest we put your gimp file and my PSDs into a submodule. What do you think?

HBehrens avatar Apr 04 '12 11:04 HBehrens

Thanks for digging up these issues - I hadn't even thought of checking it in landscape. And thanks for the compliment :) These are all fixed now.

Can you clarify what you mean by keeping the PSD's and XCF's in a submodule - another git repo?

aaronsnoswell avatar Apr 04 '12 13:04 aaronsnoswell

A little input, for the Galaxy Nexus, there should be no hardware buttons. The software buttons of 4.0.3 should be all there is. The screen should probably extend down to where the current hardware buttons are located.

Apart from that great work! It's nice being able to work on an emulator that looks like the actual device.

aravance avatar May 18 '12 20:05 aravance

Ha - Can't believe I didn't even think of that! Doh. Next time I'm using this, I'll update it to NOT have h/w buttons! Cheers :P

aaronsnoswell avatar May 27 '12 12:05 aaronsnoswell