openHASP-custom-component icon indicating copy to clipboard operation
openHASP-custom-component copied to clipboard

Published 20 hours ago • verified publisher icon HASwitchPlate

PIL uses a width,height tuple for resize() and thumbnail().

Open FreeBear-nc opened this issue 10 months ago • 3 comments

Using a 300x480 img object, and surprised to find the image was being resized to 480x300 with fitscreen=true. Looking at the image_to_rgb565 routine in the openHASP custom component, height & width had been transposed.

FreeBear-nc avatar May 02 '24 13:05 FreeBear-nc

Interesting catch... how this went by for so long

dgomes avatar May 02 '24 13:05 dgomes

If you only ever used a 1:1 aspect ratio, it would never be noticed.

FreeBear-nc avatar May 02 '24 14:05 FreeBear-nc

fitscreen is relatively new and not extensively documented/used I guess...

fvanroie avatar May 03 '24 00:05 fvanroie

I made a 0.7.3 pre-release and also set 0.7.2 as latest version.

@FreeBear-nc Please test 0.7.3 and if all is well, that will be the latest release, sometime next week.

fvanroie avatar May 13 '24 22:05 fvanroie

Appears to be functioning as expected.

FreeBear-nc avatar May 14 '24 00:05 FreeBear-nc