Mathew Topper

Results 40 comments of Mathew Topper

I have investigated adding Windows and MacOS runners, but unfortunately the Simscape toolboxes are not yet available, as per [this comment](https://github.com/matlab-actions/setup-matlab/issues/18#issuecomment-1006990188): > matlab-actions/[email protected] contains limited, undocumented, support for Windows and...

The tests are revealing 5 files that exceed the maximum version: - `examples/OSWEC/OSWEC.slx` - `examples/RM3/RM3.slx` - `examples/RM3FromSimulink/RM3FromSimulink.slx` - `source/lib/WEC-Sim/WECSim_Lib_Body_Elements.slx` - `source/lib/WEC-Sim/WECSim_Lib_Frames.slx` ``` ================================================================================ Verification failed in SLXVersionTest/testSLXVersion(Paths=p__home_runner_work_WEC_Sim_WEC_Sim_examples_OSWEC_OSWEC_slx). ---------------- Test Diagnostic:...

I added #920 to track converting the SLX files with the wrong versions.

@kmruehl, do you think it's worth adding something to the [WEC-Sim Library](https://wec-sim.github.io/WEC-Sim/master/developer/library.html) page about how to save the files to the correct version?

> @H0R5E we require the [WEC-Sim Library to be saved in 2020b](http://wec-sim.github.io/WEC-Sim/master/user/getting_started.html#matlab-requirements), but we've never required model files to also be saved in a prior version of MATLAB. Sorry, I'm...

So, another option is to get our users to turn off the compatibility check when opening Simulink files saved in newer versions. `RM3.slx` still throws this warning after being opened:...

> @H0R5E do you know is there is a way to turn off that option programmatically? Yes, the command is `set_param(0,'ErrorIfLoadNewModel','off')` EDIT: Note the above command is one-and-done. It's a...

So, the command above is *already* called [here](https://github.com/WEC-Sim/WEC-Sim/blob/f9ac900f3336548ee4ca40af73d98d9d27564fa3/source/functions/initializeWecSim.m#L461) in `initializeWecSim.m`. I really don't think this is the best place for it, as you need to run WEC-Sim before you can...

This command has been inside the `wecSim` script for a very long time. It was added by @yuyihsiang on [2017/08/16](https://github.com/WEC-Sim/WEC-Sim/commit/bddbfbbae9ccf38bb4fdf7c6ee56b3851a643277). The problem is that if we removed this command and...

So, I've gone ahead and moved `set_param(0,'ErrorIfLoadNewModel','off')` from `initializeWecSim.m` to `AddWecSimSource.m` and reduced the Simulink file version testing to the `source` folder. Happy to change again if not what you...