Plasma
Plasma copied to clipboard
H-uru
Add Elonin
Adds script files for Elonin cavern location by Dulcamara and maintained by ametist
So yeah...no idea why the scripts review blew up. Any ideas on how to fix it?
EDIT: Looks like removing that whitespace in the Python file didn't do the trick 🙁
So yeah...no idea why the scripts review blew up. Any ideas on how to fix it?
EDIT: Looks like removing that whitespace in the Python file didn't do the trick 🙁
I don't think it's your fault. It's choking on something in xGUILinkHander.py (you can see the failure details in the "Files changed" tab). It looks like the recently-merged python checker is syntactically checking against 3.8 and maybe something in that script file is requiring something newer? I don't know. @Hoikas will have to diagnose. Just didn't want you to feel too bad or tear your hair out.
Please rebase this on top of the latest master to resolve the failures.
Sorry, only just saw this. When I get home from work, I'll do that.
There's a Nexus.sdl change in here that I think is live on MOULa now, so we probably need to either merge this (since Elonin is also live on MOULa) or pull the Nexus.sdl into its own PR for merging
There's a Nexus.sdl change in here that I think is live on MOULa now, so we probably need to either merge this (since Elonin is also live on MOULa) or pull the Nexus.sdl into its own PR for merging
I think it needs the updated islmRegisterNexusLink.py, nxusBookMachine.py, and xLinkingBookDefs.py to be compatible with MOULa, too. Just replacing the nexus.sdl allows you to link to the nexus, but there are still some bugs.
Yeah, we probably need to split out the Nexus parts into a separate PR. Also, we really need to fix islmRegisterThingy.py to have a way to avoid the whole special-casing nonsense.
Given some conflicts this PR is having, going to do a fresh PR for this as well. Closing.