sniffnet icon indicating copy to clipboard operation
sniffnet copied to clipboard

Swedish translation

Open vcrn opened this issue 2 years ago • 1 comments

This PR is to add Swedish as a language option, as requested in Issue #60.

There's one thing that needs to be fixed though, and one to be discussed:

  • The letters Ä, Å and å can't be displayed, they only result in a white space. I've added these to resources/fonts/full/subset_characters.txt, but the issue persists, so I'm not sure what the cause is. Is there a certain order in which they need to be placed? Because now, I've put them in arbitrary locations in subset_characters.txt.
  • I started out by creating a 4th column for Swedish in the language selection page, but it became a bit cramped with 4 columns, so I went with adding it to the 1st column. Does this, and the placement, seem alright with you?

I've also made (what seems to me to be) some small corrections of other texts.

vcrn avatar May 22 '23 07:05 vcrn

Hi @vcrn thank you very much.

For point 1): don't worry, I'll fix it personally. (It's also necessary to include those letters in the font file but I use a program to do it, so don't worry of doing it yourself).

For point 2): I'll fix it as well!

GyulyVGC avatar May 22 '23 07:05 GyulyVGC

Update:

  • added missing characters to the font files
  • restructured language selection page
  • renamed Swedish language code to SV (SE is the code for Sweden, the country)

If you confirm everything looks good to you as well, I'll proceed merging

GyulyVGC avatar May 24 '23 10:05 GyulyVGC

Great, I'll check it out today or tomorrow!

vcrn avatar May 24 '23 11:05 vcrn

Everything looks alright to me save for one thing that I want to bring up.

I noticed when running Sniffnet on another computer where the resolution and text size is different, that the text "Applikationsprotokoll" has a tendency to be cut off if I either only use the laptop's screen or if I don't have Sniffnet on fullscreen on on the external monitor. It looks like the person doing the German translation noticed the same thing and went with the German equivalent of "Applikations-protokoll", even though a hyphen isn't supposed to be there either if it's written on one line. In Latex, you can use \- to indicate that if a line-break with a hyphen is suitable, it should be placed there, but I haven't found any similar thing in this case.

Can you run it with Swedish settings and have a look? What's your opinion on this, do you think most people will need a line-break there and that we should include it, in case we don't have an option similar to \-?

Also, I noticed that I forgot to include Å in subset_characters.txt, but it is never used anywhere so it's fine.

vcrn avatar May 25 '23 17:05 vcrn

The library I use for the GUI has a very basic text handling as of today so I don't think it supports a similar feature.

After having played a bit with the relative widths of the filter columns I have come up with sizes that correctly display all the columns title in one line without cuts, in all the currently available languages. Thank you very much for having pointed out the problem (I noticed it happened for Korean as well). Confirm everything's good when you can.

PS: you didn't forget the Å actually, I removed it by editing that file, grepping all the used characters in the src folder.

GyulyVGC avatar May 25 '23 21:05 GyulyVGC

Great, now it looks good in full-screen on both laptop screens! To me it's fine to be merged

vcrn avatar May 26 '23 06:05 vcrn

@all-contributors please add @vcrn for translation.

GyulyVGC avatar May 26 '23 08:05 GyulyVGC

@GyulyVGC

I've put up a pull request to add @vcrn! :tada:

allcontributors[bot] avatar May 26 '23 08:05 allcontributors[bot]

@all-contributors please add @vcrn for translation.

Thanks, appreciate it!

I'll see if there's something else I can help out with. Right now I'm looking into what makes one of my laptops running Manjaro able to display the flag-icons using wgpu, while my laptop that runs Arch can only do it using glow. Will see if it's due to hardware or some missing dependency

vcrn avatar May 26 '23 09:05 vcrn

@vcrn

@vcrn already contributed before to translation

allcontributors[bot] avatar May 26 '23 09:05 allcontributors[bot]

Thanks, appreciate it!

I'll see if there's something else I can help out with. Right now I'm looking into what makes one of my laptops running Manjaro able to display the flag-icons using wgpu, while my laptop that runs Arch can only do it using glow. Will see if it's due to hardware or some missing dependency

I must be thanking you man! I think that problem is "normal", Iced documented it a lot and suggests to use glow in case of problems. However, they are introducing a new software renderer that should be "universal" (but someone already reported on their Discord that in some cases this bug happens as well)

GyulyVGC avatar May 26 '23 09:05 GyulyVGC

I must be thanking you man! I think that problem is "normal", Iced documented it a lot and suggests to use glow in case of problems. However, they are introducing a new software renderer that should be "universal" (but someone already reported on their Discord that in some cases this bug happens as well)

Cool, I'll check it out!

In case it's of any interest, my laptop that could display the icons while running Manjaro can still display them after a fresh install of Arch, so it seems like it's something on the hardware level that is making my other Arch laptop unable to display them.

vcrn avatar Jun 04 '23 16:06 vcrn

Yep, absolutely. I forgot to mention that this problem usually has to do with the graphical card / adapter of the machine.

GyulyVGC avatar Jun 04 '23 16:06 GyulyVGC