gwt-material-addins icon indicating copy to clipboard operation
gwt-material-addins copied to clipboard

MaterialFileUploader : use the elemental2 XMLHttpRequest instead of manually built JsInteroped one

Open vegegoku opened this issue 8 years ago • 2 comments

Hi, i am trying to use the Material Design add-ins FileUploader and i faced some limitation when trying to add some headers to the file upload request, and those header are security headers that i cant go without.

by exploring the code i found that GMD uses a manually built JsInteroped XMLHttpRequest object which does not expose the complete features of the XMLHttpRequest which does not provide the user with the fine control over the file upload request.

the XMLHttpRequest is being fully implemented with gwt-elemental, so if we use gwt-elemental then we will be have the full feature, and we can make the XMLHttpRequest object available from the FileUploaderEvents.

vegegoku avatar Jul 10 '17 07:07 vegegoku

Thanks we will review this, I think feel free to submit a PR whenever you have time to make a simple prototype then we can refactor it later.

kevzlou7979 avatar Jul 11 '17 01:07 kevzlou7979

i am finalizing the pull request, the only issue is that to use elemental2 GWT 2.8.1 is required while the gwt-material-parent pom has dependency on GWT 2.8.0.

should i open an issue and make a pull request to upgrade to GWT 2.8.1?

@kevzlou7979 do you agree on upgrading to GWT 2.8.1?

vegegoku avatar Jul 11 '17 23:07 vegegoku