MotionCLIP icon indicating copy to clipboard operation
MotionCLIP copied to clipboard

Why input size is 25 x 6?

Open kjw9899 opened this issue 1 year ago • 6 comments

what a great work!

I'm implementing with your code, but I have a question.

In your paper, Input is orientations in 6D representation of SMPL body model(24 x 6). When I check from debugging, The input shape is 25 x 6.

Which one is right? or What component is added to 24 x 6?

kjw9899 avatar Jul 06 '23 07:07 kjw9899

I check that it seems to zero padding.

Can I ask why do this?

kjw9899 avatar Jul 06 '23 07:07 kjw9899

The last channel is for global translation. Since its dimensions are 3 and not 6 it's zero-padded.

GuyTevet avatar Aug 03 '23 01:08 GuyTevet

where is global translation from, it seems to be from the first action2motion joint, but why action2motion switch 0# and 8#?

zhipenggong avatar Aug 11 '23 02:08 zhipenggong

If I remember correctly, this switching shouldn't be in use anymore. root rotation is at [0] and root translation is at [-1] (only the first 3 entries of it)

GuyTevet avatar Aug 14 '23 23:08 GuyTevet

The switching seems to be in use: https://github.com/GuyTevet/MotionCLIP/blob/main/src/datasets/amass.py#L94

zhipenggong avatar Aug 16 '23 09:08 zhipenggong

That's a definition, not a usage, I don't see where this one is being used.

GuyTevet avatar Aug 29 '23 17:08 GuyTevet