Guy Lewin

Results 19 comments of Guy Lewin

@pintsized do you mind reviewing again before there's conflicts?

@pintsized I'll add tests, no problem. We use your library as a proxy server, in which case we want to send any HTTP request the customer sends - even the...

@pintsized added tests, also added support for 'ws' and 'wss' scheme in `parse_uri` (which I think is important because users would probably `parse_uri()` before they `connect()`)

+1 - this happens to me as well on EdenFS. Is there anything we can do to land this?

@BusyJay do you agree with my change in `src/storage.rs`?: https://github.com/tikv/raft-rs/blob/b0a374060334a35442e7da1f3769599de7a040ed/src/storage.rs#L422-L423 ? If so - it breaks a lot of tests but I can go over them and fix them. I...

> Then term should be assigned to vote response. It is assigned, but the term is still 0 when the node initializes, unless I misunderstood what you were referring to....

@BusyJay makes sense, thank you! I will initialize all our nodes with `term=1` in their Raft state.

> Though adding a check that term must not be 0 if configuration is not empty should be OK. I can work on a PR for that. We were constructing...