apollo-federation-ruby icon indicating copy to clipboard operation
apollo-federation-ruby copied to clipboard

fix: graphql-ruby 2.3 compatibility

Open Bajena opened this issue 1 year ago • 1 comments

requires merging https://github.com/Gusto/apollo-federation-ruby/issues/276 first

fixes https://github.com/Gusto/apollo-federation-ruby/issues/276

This PR:

  • Adds a new appraisal for graphql-ruby 2.3
  • Adjusts the Tracer method to support the new way of module-based tracing (https://graphql-ruby.org/queries/tracing)
  • Adjusts integration tests to use trace_with method in federated services
  • Changes documentation to inform about the new way of tracing
  • Adjusts schema generator to work with newer graphql-ruby versions (>2.3.8). It was breaking due to the lack of warden method.

Bajena avatar Sep 10 '24 09:09 Bajena

When can we expect this to be merged?

such avatar Oct 14 '24 16:10 such

@sethc2 could you please merge this? 🙏 or delegate to another maintainer? Thanks in advance.

risacan avatar Dec 06 '24 06:12 risacan

@Bajena nice! Reasonable to not delete the Gemfile.lock though? Would be very nice to get this in. Can we help?

joeljunstrom avatar Feb 18 '25 16:02 joeljunstrom

How are we doing on this PR? This is a major issue for my teams due to #276

la-jamesh avatar Mar 13 '25 14:03 la-jamesh

Hello, thx for the feedback. We'll fix the conflicts and put back the Gemfile.lock back in the following week. So we can get this merged upstream.

vaclavbohac avatar Mar 15 '25 07:03 vaclavbohac

Would love to see this get merged! Thanks for addressing this issue.

whitethunder avatar Mar 31 '25 17:03 whitethunder

:tada: This PR is included in version 3.10.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

grxy avatar Apr 02 '25 01:04 grxy

I should've released this as 3.11.0 probably. If any strong opinions I can do so.

sethc2 avatar Apr 02 '25 01:04 sethc2