apollo-federation-ruby icon indicating copy to clipboard operation
apollo-federation-ruby copied to clipboard

Published 20 hours ago • verified publisher icon Gusto

fix: Support inline variables for _entities

Open cmschuetz opened this issue 4 years ago • 3 comments

Summary

  • Updates Any.coerce_input to handle the case when value is an instance of GraphQL::Language::Nodes::InputObject
  • Newer releases of GraphQL automatically convert inline query variables to input objects

While it's highly unlikely that Apollo Gateway will send queries with inline variables, when unit testing & manually sending _entitiy queries directly to federation services, we often will use inline variables.

cmschuetz avatar Oct 14 '20 18:10 cmschuetz

Hey @rylanc, any chance you could give this a look?

cmschuetz avatar Nov 11 '20 20:11 cmschuetz

Would like to +1 merging this fix.

caomania avatar Apr 15 '21 15:04 caomania

Sorry for taking so long to get to this PR.

This makes sense, we should be supporting inlined variables. Let me see if I can revive this PR.

daemonsy avatar May 20 '22 18:05 daemonsy

I'm gonna close this one team, i'm so far removed from this stuff these days. Hope you found a path forward here

cmschuetz avatar Aug 22 '23 18:08 cmschuetz