August
August
Tests fail as expected for enabled gradle daemon (before the fix): https://github.com/flutter/flutter/pull/142498/checks?check_run_id=21166626702 I reverted the revert with 309767ce37cfc966bd153a2e4b9720795057d599 and added the tests with 851fe0de9bf3e6c0f70c859ff6fff7006ceca34c and added the fix with cddc01714d0a1d6b25788a0347ab2e2b603480d7
CC @bartekpacia @camsim99 @reidbaker
@reidbaker small ping if there's time to finish the review :)
Thank you :) > The test added LGTM but can you give some context as to why [cddc017](https://github.com/flutter/flutter/commit/cddc01714d0a1d6b25788a0347ab2e2b603480d7) fixes https://github.com/flutter/flutter/issues/141940? As stuartmorgan described in https://github.com/flutter/flutter/issues/141940#issuecomment-1912645081 a Singleton persists across builds...
Thank you for reviewing!
Same problem with `await Future.delayed(const Duration(seconds: 5));`
This was my mistake: I forgot this line `IntegrationTestWidgetsFlutterBinding.ensureInitialized();` https://docs.flutter.dev/cookbook/testing/integration/introduction#4-write-the-integration-test So it avoids using the fake async behavior for native integration tests. I wonder why this is the default behavior...
I think the problem is that since Flutter 3.7.0 OpenGL support is removed, and therefore only CI with Metal GPU support can handle the tests: See also: https://github.com/actions/runner-images/issues/1779#issuecomment-707071183 https://github.com/actions/runner-images/issues/183#issuecomment-1407410429 https://github.com/flutter/flutter/issues/108304...
@Lyokone indeed, the tests now also run with recent versions of flutter with `macos-13` image on GitHub Actions. On the `macos-12` image it still fails. I wrote a little test...
Sorry first I haven't had time for a review and also somehow forgot it :sweat_smile: I saw the maintainers now provide a build script: https://github.com/haiwen/seafile-docker/tree/master/build I will give feedback if...