laravel-views icon indicating copy to clipboard operation
laravel-views copied to clipboard

Published 20 hours ago • verified publisher icon Gustavinho

Add a min height?

Open elfeffe opened this issue 3 years ago • 10 comments

68c8132afcb63203761426f664e878cc

I think you should add a min-h-screen to the components

elfeffe avatar May 26 '21 08:05 elfeffe

Hi @elfeffe I saw your PR, I'll merge it

Gustavinho avatar May 26 '21 17:05 Gustavinho

Hey guys - I can understand why you want a min height, but now this causes other issues. It creates a huge gap below the views. Eg. try creating two views one after another when there are minimal rows and there will be a huge gap between them.

Maybe there's another way to fix filter dropdown? Or at least have an easy way to remove the min height?

df999 avatar Jun 04 '21 19:06 df999

Paste some screenshot please. I will check it.

elfeffe avatar Jun 04 '21 20:06 elfeffe

table views The height of the gap is relative to the screen height of course.

In the blade file, I just have two components, one after another:

<livewire:forms.project-table-view />
<livewire:forms.project-table-view />

df999 avatar Jun 04 '21 20:06 df999

Thanks @df999 for raising this, yeah the min-height was to avoid the filter cutting off but you are right, there should be a better way to fix this, sorry for this issue I should have tested it this way, I will add this test scenario before releasing a new version

Gustavinho avatar Jun 05 '21 16:06 Gustavinho

Okay thanks. Perhaps there's a z-index solution to have it on top of the content below.

df999 avatar Jun 05 '21 17:06 df999

Hi @elfeffe what version of the package and browser did you use to see this issue? by any chance are you using your own tailwindcss file? if that so, are you including laravel views path to your tailwind purge settings?

Gustavinho avatar Jun 07 '21 02:06 Gustavinho

@Gustavinho Are you sure the question is for me? I'm using Latest Chrome and Firefox, with default TailwindCSS, local, not from CDN. The package, I was using the latest stable version.

elfeffe avatar Jun 07 '21 08:06 elfeffe

Yeah @elfeffe, thanks, I'm trying to fix the original issue but I haven't been able to replicate it again and I just wanted to be sure that I'm using the correct environment to replicate it

I've tested it with

  • LaravelViews 2.2.4, 2.2.3, 2.2.2, 2.2.1, 2.2.0
  • Local Tailwindcss build with/without purging LaravelViews files,
  • LaravelViews default tailwindcss file
  • Chrome, Firefox

This is how it looks image

And this is how I'm rendering the table view

<body class="bg-gray-100">
        <div class="bg-white">
            <livewire:my-users-table-view />
        </div>
</body>

Not sure if I'm missing something else to see this behavior, do you have something different?

Gustavinho avatar Jun 08 '21 03:06 Gustavinho

@df999 is right about space but it is something else I think.

I've started using this after this update so I don't know what has changed what.

Screenshot (340)

Above image is toolbar.blade.php from component/toolbar .

and issue is :

used for search bar and filter line 11 : <div class="flex-1"> line 16 : <div class="flex space-x-1 flex-1 justify-end items-center mb-4">

image

Screenshot (342)

Look above SS this two line are printing when there is no search and filter enabled.

I haven't forked any project yet otherwise I'll submit request. Maybe another time. Thanks

var2611 avatar Jan 03 '22 18:01 var2611