lycheesync icon indicating copy to clipboard operation
lycheesync copied to clipboard

Generating medium thumbnails

Open ru-voland opened this issue 7 years ago • 6 comments

Thank you for good tool for Lychee!

I make little adaptation to support medium sized thumbnails generation. Code is based on the @palitu fork (branch: patch-[1..3]). I just added an additional parameter to the conf.json to on/off this feature and organized code in small different way.

ru-voland avatar Feb 06 '18 15:02 ru-voland

glad to see it hasn't gone to waste :)

On Tue, Feb 6, 2018 at 11:03 PM, Andrey [email protected] wrote:

Thank you for good tool for Lychee!

I make little adaptation to support medium sized thumbnails generation. Code is based on the @palitu https://github.com/palitu fork (branch: patch-[1..3]). I just added an additional parameter to the conf.json to on/off this feature and organized code in small different way.

You can view, comment on, or merge this pull request online at:

https://github.com/GustavePate/lycheesync/pull/81 Commit Summary

  • exclude venv 3.5
  • Generating medium thumbnails. Based on the code from @palitu (branch: patch-[1..3])

File Changes

Patch Links:

  • https://github.com/GustavePate/lycheesync/pull/81.patch
  • https://github.com/GustavePate/lycheesync/pull/81.diff

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GustavePate/lycheesync/pull/81, or mute the thread https://github.com/notifications/unsubscribe-auth/AGU9IIEY7LAI9kpqb9AcPdrnZtEQc1Uhks5tSGmngaJpZM4R7MQ1 .

palitu avatar Feb 06 '18 23:02 palitu

Raaaaah ! It breaks all the tests :D I will manually patch this a bit later

GustavePate avatar Feb 17 '18 14:02 GustavePate

Coverage Status

Coverage increased (+0.2%) to 74.084% when pulling 8627c1b78b8584be6c7d0c04bf33f8cad9d90d76 on ru-voland:adapted into 043bc70d6f56ac791075bdc033b70d66f26ec60f on GustavePate:master.

coveralls avatar Feb 17 '18 19:02 coveralls

Coverage Status

Coverage increased (+0.2%) to 74.084% when pulling 8627c1b78b8584be6c7d0c04bf33f8cad9d90d76 on ru-voland:adapted into 043bc70d6f56ac791075bdc033b70d66f26ec60f on GustavePate:master.

coveralls avatar Feb 17 '18 19:02 coveralls

Coverage Status

Coverage increased (+0.2%) to 74.084% when pulling 8627c1b78b8584be6c7d0c04bf33f8cad9d90d76 on ru-voland:adapted into 043bc70d6f56ac791075bdc033b70d66f26ec60f on GustavePate:master.

coveralls avatar Feb 17 '18 19:02 coveralls

Looks like everything is OK now :-) Just added a new param to the test conf

ru-voland avatar Feb 17 '18 19:02 ru-voland