react-native-siri-shortcut icon indicating copy to clipboard operation
react-native-siri-shortcut copied to clipboard

Crash when donating shortcut with scene delegate

Open JensDeTaey27 opened this issue 2 years ago • 6 comments

Hi,

We see in crashlytics following crashes with a small percentage of the user base. We can't reproduce this but we know it happens when the method donateShortcut is executed as seen in the stacktrace. This crash reported after we switched to a phone scene delegate. So maybe that has something to do with it.

Crashed: com.facebook.react.RNSiriShortcutsQueue
0  libdispatch.dylib              0x89c0 dispatch_async + 188
1  libdispatch.dylib              0x89c0 dispatch_channel_async + 188
2  Synapse                        0x8964 -[SYDefaultsClient indicatorCoverageWithCompletion:] + 144
3  Synapse                        0x1d5c0 -[SYActivityObserver _reportActiveUserActivityChangeIfNeeded:context:] + 316
4  Synapse                        0x1e050 -[SYActivityObserver userActivityDidBecomeCurrent:current:] + 176
5  UserActivity                   0x2480 -[UAUserActivity becomeCurrent] + 880
6  APPNAME                       0x5631bc -[RNSSSiriShortcuts donateShortcut:] + 216 (RNSSSiriShortcuts.m:216)
7  CoreFoundation                 0x74704 __invoking___ + 148
8  CoreFoundation                 0x20b6c -[NSInvocation invoke] + 428
9  CoreFoundation                 0x20584 -[NSInvocation invokeWithTarget:] + 64
10 APPNAME                       0x5a6288 -[RCTModuleMethod invokeWithBridge:module:arguments:] + 587 (RCTModuleMethod.mm:587)
11 APPNAME                        0x5a8400 facebook::react::invokeInner(RCTBridge*, RCTModuleData*, unsigned int, folly::dynamic const&, int, (anonymous namespace)::SchedulingContext) + 183 (RCTNativeModule.mm:183)
12 APPNAME                       0x5a8088 invocation function for block in facebook::react::RCTNativeModule::invoke(unsigned int, folly::dynamic&&, int) + 419 (Optional.h:419)
13 libdispatch.dylib              0x24b4 _dispatch_call_block_and_release + 32
14 libdispatch.dylib              0x3fdc _dispatch_client_callout + 20
15 libdispatch.dylib              0xb694 _dispatch_lane_serial_drain + 672
16 libdispatch.dylib              0xc1e0 _dispatch_lane_invoke + 384
17 libdispatch.dylib              0x16e10 _dispatch_workloop_worker_thread + 652
18 libsystem_pthread.dylib        0xdf8 _pthread_wqthread + 288
19 libsystem_pthread.dylib        0xb98 start_wqthread + 8

Using latest version V3.2.2

JensDeTaey27 avatar Dec 12 '22 15:12 JensDeTaey27

hello @JensDeTaey27 did you find fix for this issue

hagar0459 avatar Feb 13 '23 06:02 hagar0459

Hello @hagar0459, no I haven't found a fix for this yet.

JensDeTaey27 avatar Feb 13 '23 15:02 JensDeTaey27

I am having the same issue and no fix yet

mklb avatar May 26 '23 13:05 mklb

I don't have enough context in this issue to be able to debug this issue. Are you able to provide an example project that reproduces this issue?

Gustash avatar Jun 11 '23 02:06 Gustash

Happens for me too, donating or suggesting. When I build to a physical device in debug mode it works fine for the most part but release crashes instantly and trying to go back into the app doesn't work afterwards.

IOS 16.3.1

farsoudi avatar Jul 10 '23 20:07 farsoudi

Happens for me too, donating or suggesting. When I build to a physical device in debug mode it works fine for the most part but release crashes instantly and trying to go back into the app doesn't work afterwards.

IOS 16.3.1

{ "name": "appName", "version": "0.0.1", "private": true, "scripts": { "android": "react-native run-android", "ios": "react-native run-ios", "lint": "eslint .", "start": "react-native start", "test": "jest" }, "dependencies": { "expo": "^49.0.0", "expo-haptics": "~12.4.0", "react": "18.2.0", "react-native": "0.72.1", "react-native-siri-shortcut": "^3.1.0" }, "devDependencies": { "@babel/core": "^7.20.0", "@babel/preset-env": "^7.20.0", "@babel/runtime": "^7.20.0", "@react-native/eslint-config": "^0.72.2", "@react-native/metro-config": "^0.72.7", "@tsconfig/react-native": "^3.0.0", "@types/metro-config": "^0.76.3", "@types/react": "^18.0.24", "@types/react-test-renderer": "^18.0.0", "babel-jest": "^29.2.1", "eslint": "^8.19.0", "jest": "^29.2.1", "metro-react-native-babel-preset": "0.76.5", "prettier": "^2.4.1", "react-test-renderer": "18.2.0", "typescript": "4.8.4" }, "engines": { "node": ">=16" } }

farsoudi avatar Jul 13 '23 20:07 farsoudi