Hyprshot icon indicating copy to clipboard operation
Hyprshot copied to clipboard

Add move-cursor option

Open Ben9986 opened this issue 1 year ago • 1 comments

Sometimes the cursor can get in the way of screenshots, especially region grabs (see below) image

This PR allows the user to temporarily move the cursor whilst the screenshot is taken, and move it back after. Example:

hyprshot -m region --move-cursor 0,0

This will move the cursor to the top left monitor corner, take the screenshot, then return it to where it was when the selection was made. This happens in less than a second for me.

This is similar to #36 but there you can still see the cursor in the screenshot if certain conditions are met.

Ben9986 avatar May 07 '24 21:05 Ben9986

I've recently realised this is actually an issue with software cursors, which currently still need to be used on nvidia. Software cursors are supposed to work as of recent but are currently a lil buggy. So this PR might not be needed if/when software cursors are fixed on nviida.

Ben9986 avatar May 11 '24 11:05 Ben9986

@BenCarmichael01 I would rather not merge something that is just a workaround for an Nvidia issue, specially if it might be fixed in the future.

I'll leave it up to you if this PR really should be merged or not. You can close it if you think Nvidia will fix this issue at some point, or @ me here if you think this is really needed in the long run.

Gustash avatar Jun 01 '24 18:06 Gustash

Actually I think software cursors seem to be fixed now on nvidia so this shouldn't be needed. Haven't tested recently and don't have the time atm.

Either way since the --freeze option has been added now, I don't think this is needed.

I'll go ahead and close this. Thanks!

Ben9986 avatar Jun 01 '24 18:06 Ben9986