gumtree icon indicating copy to clipboard operation
gumtree copied to clipboard

Published 20 hours ago • verified publisher icon GumTreeDiff

Diff class support for Resources

Open rpau opened this issue 2 years ago • 2 comments

This commit is adding a new compute method to support the diff processing of resources instead of paths.

This functionality is intersting when the files that need to be computed are not in the local file and are downloaded from the Internet using APIs in memory.

rpau avatar Sep 11 '22 19:09 rpau

Hi and thanks a lot for the PR!

It seems that there are a couple of formatting issues, but otherwise seems good!

Can you fix the formatting issues?

Cheers!

jrfaller avatar Sep 12 '22 14:09 jrfaller

Sure, Now I'll review the issues reported during the build. Sorry for that.

rpau avatar Sep 13 '22 10:09 rpau

@jrfaller I need again your approval to run the workflow. Sorry, hopefully this is the good one :)

rpau avatar Oct 20 '22 08:10 rpau

@jrfaller Hopefully now the test error is fixed :)

rpau avatar Oct 31 '22 09:10 rpau

@jrfaller Can you merge it now? :)

rpau avatar Nov 02 '22 11:11 rpau

@rpau done! Thanks for cleaning-up the PR!

jrfaller avatar Nov 06 '22 09:11 jrfaller