Guldoman

fix: avoid iterating over a changing table in `run_threads`

5

This is done to avoid iterating over a table that can change in the meantime. More precisely the issue appears if a thread is removed from the table, we yield...

Ask all the "optional" questions before beginning to install plugins

4

For example at the moment if someone leaves the terminal while a download is in progress, they might get back to a prompt that will trigger another download.

Using ``` lpm run https://github.com/Guldoman/lite-xl-plugins:PR_bump_lsp https://github.com/Guldoman/lite-xl-lsp_copilot:master lsp_copilot ``` the `lsp` version that gets installed is the one from the default plugins repo, and not the one in the `PR_bump_lsp` branch....

Is some cases it's possible to get an error like: ``` Fri Jan 26 23:55:17 2024 [ERROR] error running .../.config/lite-xl/lpm/bottles/bb3ede91839ca81b555fa2338de14fb3d7ec12ad9512d1155f0ec5e2a3c5770d/user/plugins/plugin_manager/lpm.x86_64-linux uninstall cold_lime --json --mod-version=3 --quiet --progress --userdir=.../.config/lite-xl/lpm/bottles/bb3ede91839ca81b555fa2338de14fb3d7ec12ad9512d1155f0ec5e2a3c5770d/user --datadir=.../.config/lite-xl/lpm/bottles/bb3ede91839ca81b555fa2338de14fb3d7ec12ad9512d1155f0ec5e2a3c5770d/data --binary=.../.config/lite-xl/lpm/bottles/bb3ede91839ca81b555fa2338de14fb3d7ec12ad9512d1155f0ec5e2a3c5770d/lite-xl --assume-yes:...

Compose key keypress events aren't sent to IME under X11

8

Key presses of the compose key get eaten by https://github.com/libsdl-org/SDL/blob/f4d1f5ed54aecbbccf20e4967b14f965196b7694/src/video/x11/SDL_x11events.c#L773-L796 and are not sent to https://github.com/libsdl-org/SDL/blob/f4d1f5ed54aecbbccf20e4967b14f965196b7694/src/video/x11/SDL_x11events.c#L1072-L1076 Key releases are handled as expected. Because of this, TEXTEDITING events aren't generated while...

Needs some quick testing.