Guillaume Gomez comments

Results 1141 comments of


                                            Guillaume Gomez

rustdoc: use a more compact encoding for implementors/trait.*.js

Looks good to me but I'm curious about the perf impact so let's check. @bors try @rust-timer queue

rustdoc: use a more compact encoding for implementors/trait.*.js

Congrats for the perf fix, this is really awesome! @bors r+

Use core c_void type and remove need for libc

Oh, that requires to upgrade the minimum supported rust version... @retep998: Should I automatically detect the version of the rustc compiler like `libc` does to enable it through a feature...

Support defining style class(es) in builder constructors

I guess it can be closed then?

Inconsistent column number types

Indeed. Transferring the issue.

Add doc example to call AppInfo launch without files argument

I guess we could add a code example. Let me rename the issue then.

Use example for gtk::Dialog should contain a Rust example rather than a C example

No, it's a discussion I had with people in GNOME and the outcome is: it's complicated.

Check subclass gtk check

Still remains the question if we should put this check before running it in the parent.

Add example: Combobox with list store

Apart from my comments and the clippy lint, looks good to me.

gtk-rs on Windows with MSVC should be possible with zero attrition

> note: I'm not sure if the best place is here or at sys repository, but as any user looking for gtk-rs on windows will tend to land here, I'm...