guake icon indicating copy to clipboard operation
guake copied to clipboard

Published 20 hours ago • verified publisher icon Guake

Add an appstream file

Open pypingou opened this issue 11 years ago • 16 comments

With the renew of guake we should make sure it shows up in gnome-software by shipping an appstream file in the sources

http://www.freedesktop.org/software/appstream/docs/

pypingou avatar Feb 13 '14 22:02 pypingou

agreed!

gsemet avatar Feb 13 '14 22:02 gsemet

And an "AppData" (see #325): http://people.freedesktop.org/~hughsient/appdata/

gsemet avatar Jul 03 '14 10:07 gsemet

Can someone help me on this matter I frankly have no idea what to do?

gsemet avatar Apr 28 '15 13:04 gsemet

We should include in the sources a file to be used by software application and install it upon install.

This is just like another .desktop file but with another set of information in it

pypingou avatar Apr 28 '15 13:04 pypingou

which are... ? do you have sample for similar apps?

gsemet avatar Apr 28 '15 14:04 gsemet

It's in the link you gave above :)

pypingou avatar Apr 28 '15 15:04 pypingou

I reported it to be an gnome-software issue, as I thought it was an error on their end:

https://gitlab.gnome.org/GNOME/gnome-software/issues/647

str avatar Apr 22 '19 13:04 str

I see there is branch merged solving this issue, dated Oct 2018. When will it be released?

str avatar Apr 22 '19 13:04 str

Do you mean master? I still have some fixes to do until release of next version

gsemet avatar Apr 22 '19 13:04 gsemet

OK, it looks like we have 2 issues:

  1. The appdata is in the wrong folder.

I saw the file at /usr/share/guake/data/guake.appdata.xml, but it looks like other pacakges are installing the appdata at /usr/share/metainfo/$appName.appdata.xml OR /usr/share/appdata/$appName.metainfo.xml OR /usr/share/appdata/$appName.appdata.xml

It looks like we've just need to move the file to the right folder.

  1. guake.desktop is a symlink

/usr/share/applications/guake.desktop points to ../guake/data/guake.template.desktop BUT AppStream's documentation says:

No symbolic links

Since the AppStream Generator relies on packages' md5sums file to determine the contents of a package, symbolic links are not recognized. So please do not symlink .desktop files or icons from other places into /usr/share/pixmaps or the /usr/share/icons/hicolor subdirectories, because the generator will not see these files then. Relying on symbolic links in icon-theme packages is fine though. https://wiki.debian.org/AppStream/Guidelines#No_symbolic_links

I don't know if we have to follow the 2 rules. I'm still digging.

str avatar May 07 '20 22:05 str

OK, pullrequest added https://github.com/Guake/guake/pull/1754

str avatar May 08 '20 15:05 str

commit c9a7c66eeed258c1dd1beb453d1d118a01a1101f placed guake.desktop.metainfo.xml to $(DESTDIR)/metainfo/ instead of $(DESTDIR)$(datadir)/metainfo/. In package this file will be placed to /metainfo, but standard (https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html#qsr-app-introduction) says:

Applications can ship one or more files in /usr/share/metainfo/%{id}.metainfo.xml

/usr/share part ($(datadir)) is missing in the installation path. Please, return $(datadir) to installation path.

sibskull avatar Oct 09 '21 15:10 sibskull

The fastest way to get this in would be to make a pull request yourself with the changes that you feel are necessary. I can't approve my own pull requests but I can do so for other people, so a change I make may take an indeterminate amount of time until it gets looked at and merged.

Davidy22 avatar Oct 09 '21 15:10 Davidy22

Thank you for the attention. Please, review pull request #1928

sibskull avatar Oct 10 '21 09:10 sibskull

Looks like we've added this file a good long time ago. Closing.

Davidy22 avatar Oct 13 '21 12:10 Davidy22

Nevermind, just tried installing gnome-software to do a quick sanity check and looks like we still have a bit more to do to make it show up.

Davidy22 avatar Oct 13 '21 13:10 Davidy22