Guake always starts in fullscreen once fs is used

[mutech]

Describe the bug

After fullscreen has been used, guake will always appear in fullscreen mode from then on.

Expected behavior

Guake should either appear in the same configuration when it was hidden or always start in normal or fullscreen mode according to the setting of the main window.

Actual behavior

Guake respects the "start fullscreen setting" = "off" until fullscreen has been used and from then on ignores it on activation for as long as guake runs.

To Reproduce

• Activate guake using the hotkey
  • Observe: window appears in normal mode
• Deactive guake using the hotkey and activate it again
  • Observe: window appears in normal mode
• Change to fullscreen mode and back to normal mode
  • Observe: window appears in normal mode
• Activate guake using the hotkey
  • Observe: window appears in fullscreen mode from then on, no matter what you do.

---

$ guake --support

Guake Version: 3.8.5

Vte Version: 0.68.0

Vte Runtime Version: 0.68.0

---

GTK+ Version: 3.24.33

GDK Backend: <GdkX11.X11Display

---

Desktop Session: ubuntu-xorg

---

Display: :0

RGBA visual: True

Composited: True

• Monitor: 0 - APP DP-1
  • Geometry: 2560 x 1440 at 0, 0
  • Size: 597 x 336 mm²
  • Primary: True
  • Refresh rate: 59.95 Hz
  • Subpixel layout: unknown

[mutech]

There is a bit more to this: I'm using a custom gnome keyboard shortcut for fullscreen (not F11) while guake itself is configured to use F11 as shortcut.

If I change the guake window back from fullscreen using the guake shortcut, it works as expected, while using the gnome-shortcut also changes from fullscreen to normal, but as the described effect.

When I'm using the same keyboard shortcut in gnome and guake, the bug is there (guake probably never sees the keyboard shortcut).

So this bug appears only if the windowmanager/desktop sends a fullscreen request and not if guake processes its own keyboard shortcut.

Apparently, the window geometry used for restoring the window after a hide is not recorded correctly when a WM leave fullscreen request comes in.