GsUpgrader class>>upgradeGLASSForGsDevKit_home may cause issues when upgrading

[dalehenrich]

Upgrading to 3.3.0 from 3.2.12 using GsUpgrader class>>upgradeGLASSForGsDevKit_home results in the following error during tODE install:

========>Server Stack: 'AssertionFailure: Assertion failed'
1 [] in  ExecBlock1 (GsUpgrader class) >> batchErrorHandlingDo: @8 line 9  [GsNMethod 292858881]
2 AssertionFailure (AbstractException) >> _executeHandler: @4 line 8  [GsNMethod 205057793]
3 AssertionFailure (AbstractException) >> _signalWith: @1 line 1  [GsNMethod 205058817]
4 AssertionFailure (AbstractException) >> signal: @3 line 7  [GsNMethod 205063681]
5 AssertionFailure class (AbstractException class) >> signal: @3 line 4  [GsNMethod 205047809]
6 MetacelloProjectRegistration (Object) >> assert: @4 line 4  [GsNMethod 234370305]
7 MetacelloProjectRegistration >> configurationProjectSpec: @5 line 9  [GsNMethod 309247233]
8 [] in  ExecBlock1 (MetacelloMCBaselineOfProjectSpec) >> copyForRegistration:onWrite: @6 line 13  [GsNMethod 309942017]
9 ExecBlock1 (ExecBlock) >> cull: @7 line 4  [GsNMethod 234455297]
10 [] in  ExecBlock0 (MetacelloProjectRegistration) >> configurationProjectSpecIfPresent:ifAbsent: @3 line 2  [GsNMethod 309429761]
11 MetacelloMCProjectSpec (Object) >> ifNotNil:ifNil: @6 line 14  [GsNMethod 202736129]
12 MetacelloProjectRegistration >> configurationProjectSpecIfPresent:ifAbsent: @3 line 2  [GsNMethod 309688321]
13 [] in  ExecBlock0 (MetacelloMCBaselineOfProjectSpec) >> copyForRegistration:onWrite: @3 line 10  [GsNMethod 310034177]
14 UndefinedObject (Object) >> ifNotNil:ifNil: @10 line 17  [GsNMethod 202736129]
15 MetacelloProjectRegistration >> baselineProjectSpecIfPresent:ifAbsent: @3 line 2  [GsNMethod 309248513]
16 MetacelloMCBaselineOfProjectSpec >> copyForRegistration:onWrite: @3 line 4  [GsNMethod 309849601]
17 [] in  ExecBlock1 (MetacelloScriptEngine) >> lock @4 line 18  [GsNMethod 300919553]
18 MetacelloProjectRegistration >> copyOnWrite: @9 line 13  [GsNMethod 309684993]
19 [] in  ExecBlock2 (MetacelloScriptEngine) >> lock @3 line 15  [GsNMethod 300534273]
20 [] in  ExecBlock1 (MetacelloProjectRegistration class) >> registrationForProjectSpec:ifAbsent:ifPresent: @3 line 6  [GsNMethod 309421057]
21 [] in  ExecBlock1 (MetacelloProjectRegistry) >> registrationFor:ifPresent:ifAbsent: @3 line 10  [GsNMethod 233868545]
22 Dictionary (AbstractDictionary) >> at:ifPresent: @5 line 6  [GsNMethod 234326529]
23 MetacelloProjectRegistry >> registrationFor:ifPresent:ifAbsent: @17 line 9  [GsNMethod 226545409]
24 MetacelloProjectRegistration class >> registrationForProjectSpec:ifAbsent:ifPresent: @6 line 5  [GsNMethod 309711617]
25 [] in  ExecBlock0 (MetacelloScriptEngine) >> lock @8 line 8  [GsNMethod 300148993]
26 ExecBlock0 (ExecBlock) >> ensure: @2 line 12  [GsNMethod 203455233]
27 MetacelloProjectRegistration class >> copyRegistryRestoreOnErrorWhile: @9 line 14  [GsNMethod 309252097]
28 MetacelloScriptEngine >> lock @3 line 4  [GsNMethod 300812801]
29 MetacelloScriptEngine (Object) >> perform:withArguments: @1 line 1  [GsNMethod 203166721]
30 [] in  ExecBlock1 (MetacelloScriptExecutor) >> execute: @12 line 15  [GsNMethod 309661697]
31 [] in  ExecBlock1 (MetacelloScriptApiExecutor) >> executeString:do: @6 line 6  [GsNMethod 309663745]
32 Array (Collection) >> do: @6 line 10  [GsNMethod 203580417]
33 MetacelloScriptApiExecutor >> executeString:do: @7 line 4  [GsNMethod 309537793]
34 String >> execute:against: @2 line 2  [GsNMethod 234352641]
35 MetacelloScriptApiExecutor (MetacelloScriptExecutor) >> execute: @7 line 9  [GsNMethod 309540353]
36 Metacello >> execute:args: @9 line 5  [GsNMethod 300721665]
37 Metacello >> lock @2 line 4  [GsNMethod 300720641]
38 [] in  Executed Code  @57 line 38  [GsNMethod 310142209]
39 ExecBlock0 (ExecBlock) >> on:do: @3 line 44  [GsNMethod 203448321]
40 GsUpgrader class >> batchErrorHandlingDo: @3 line 3  [GsNMethod 240173569]
41 Executed Code  @4 line 6  [GsNMethod 309891073]
42 <Reenter marker>

To workaround this issue, edit the $GS_HOME/sys/default/client/server-bootstrap-scripts/upgradeGLASS.ws file to change line 51 from:

  (Smalltalk at: #'GsUpgrader') upgradeGLASSForGsDevKit_home ]

to:

  (Smalltalk at: #'GsUpgrader') upgradeGLASS ]