Error during clone_gs_client_dev execution

[victornoel]

Hi,

I was trying to install GsDevKit and I got the following error appear:

=================
   GsDevKit script: clone_gs_client_dev -o GsDevKit
              path: /GsDevKit_home/bin/private/clone_gs_client_dev
=================
=================
   GsDevKit script: cloneGitHubProject GsDevKit GsDevKit_gs_client_dev dev
              path: /GsDevKit_home/bin/private/cloneGitHubProject
=================
Cloning into 'dev'...
...finished :: cloneGitHubProject GsDevKit GsDevKit_gs_client_dev dev
>>>>>>
basename: missing operand
Try 'basename --help' for more information.
   Checkout 
>>>>>>
fatal: Not a git repository: '/.git'
...finished :: clone_gs_client_dev -o GsDevKit

It seems that checkoutClone "$GSDEVKIT_DEV_GIT_CHECKOUT" "$GS_CLIENT_DEV" fails because $GS_CLIENT_DEV is not set.

The reason it is not set seems to be because it should be set by source "${GS_HOME}/bin/defGsDevKit.env" but it is not since the "$GS_HOME/dev" directory does not exists yet when defGsDevKit.env is sourced.

It is only created just before the call to checkoutClone.

That's how I "fixed" this but I don't know if it's clean enough:

diff --git a/bin/private/clone_gs_client_dev b/bin/private/clone_gs_client_dev
index 8690f97..a02f944 100755
--- a/bin/private/clone_gs_client_dev
+++ b/bin/private/clone_gs_client_dev
@@ -54,6 +54,7 @@ source "${GS_HOME}/bin/private/gitFunctions"
 
 pushd "${GS_HOME}" >& /dev/null
   "${GS_HOME}/bin/private/cloneGitHubProject" $modeArg $organization GsDevKit_gs_client_dev dev
+  source "${GS_HOME}/bin/defGsDevKit.env"
   checkoutClone "$GSDEVKIT_DEV_GIT_CHECKOUT" "$GS_CLIENT_DEV"
 popd >& /dev/null