todo-tree icon indicating copy to clipboard operation
todo-tree copied to clipboard

Add control on border attribute

Open mrvkino opened this issue 4 years ago • 4 comments

Hi,

I tried to reproduce the following highlight of a tag

image

But I found out it is not possible with the control given. The closest I got was:

image

I would like to have the following control:

"border": "1px solid #2aa198"

Maybe I missed something, but looking at the issue and documentation it seems border control is limited to radius.

Thanks

mrvkino avatar Nov 26 '21 15:11 mrvkino

I was wondering why we cannot put any of the qualifiers defined in the VSCode CSS instead of having each of them processed individually as done here?

Is there a performance or discoverability idea behind that?

mrvkino avatar Nov 26 '21 18:11 mrvkino

Yes, unfortunately the styling very limited. I would also like to be able to put an outline around the highlight, but it doesn't work.

The reason the entire set of rules isn't available is that they have to be applied as a decoration and originally a lot of them were not available. It might be simpler to provide a way to specify any of them, although a lot of them will not make any sense.

I'll add it as a feature request and see if something can be done.

Gruntfuggly avatar Nov 29 '21 22:11 Gruntfuggly

In the meantime, If adding the border styling can be done in a similar fashion as the other (aka I can copy the structure), I can try to give It a shot.

I have not done much JavaScript/TypeScript development, but I can try to help.

mrvkino avatar Nov 30 '21 13:11 mrvkino

border options are now available in the API, can these be added now? I've checked and "border": "1px solid #2aa198" still doesnt work

eversonl avatar Mar 07 '24 21:03 eversonl