Gabriel Grubba

Results 183 comments of Gabriel Grubba

Hey, @StorytellerCZ Will happly merge this one but would like to have docs on this one. An Example would be nice as well. I think it could be added in...

> Wow, the tests passed. No idea what changed, I was hoping that the upstream changes would have positive impact, but this is a bit unexpected. Rather suspicious. Agreed, not...

> I'll try to pull together documentation, and that will trigger another CI run which should tell us if it was just a fluke or not. Sure, If possible add...

Hey @StorytellerCZ, you, by any chance, got to do these docs?

I guess it were flaky tests :/ (now there are 3 failing)

Yeah at least 2 is from here. I've added this line here to try to find where are problems coming from https://github.com/meteor/meteor/blob/1d4aa133de2f29571f9962f97540207badffbbd0/packages/test-in-console/puppeteerRunner.js#L32

If you pull from 2.13 I have solved the CI( is green at least in 2.13)

lets see if things just work™️

Hey @coachdan this still needs implementing what @matheusccastroo said: > Looking at the changes, we would need to set the splash as a `preference` tag and use the new `adaptive...

Still needs to solve this issue: Looking at the changes, we would need to set the splash as a preference tag and use the new adaptive splash screen, but this...