growstuff
growstuff copied to clipboard
Growstuff
Connect to Facebook
Members should be able to connect their Growstuff account to their Facebook accounts. This should use OAuth. The resulting linked accounts should be displayed on the Growstuff member's profile.
This is linking, not necessarily sign-in via Facebook. It allows someone with a Growstuff password to have facebook linked as well, which is a step beyond #645 though both could be done at once.
This one is now plausible with the above PR, but probably needs a bit more discussion.
We can do the 'add facebook credential' step fairly easily - the existing authentications_controller seems to be 99% there; but we probably want to think about what kind of information we want to read (user location, photos, etc), and if there is any we want to write.
I think probably we don't want to read location - better to give members the choice of how granular to specify it for Growstuff separately. Reading photos is a nice feature for the long-term, as it will make adding photos to gardens much easier, but not necessary for MVP. Part of the aim of this eventually is to be able to write - adding optional "Share to Facebook" and "Share to Twitter" buttons whenever you plant or harvest something, and so on.
Technically, we could have had share buttons ages ago. They can be done without the API.
On Fri, Aug 21, 2015, 3:38 AM Cesy [email protected] wrote:
I think probably we don't want to read location - better to give members the choice of how granular to specify it for Growstuff separately. Reading photos is a nice feature for the long-term, as it will make adding photos to gardens much easier, but not necessary for MVP. Part of the aim of this eventually is to be able to write - adding optional "Share to Facebook" and "Share to Twitter" buttons whenever you plant or harvest something, and so on.
— Reply to this email directly or view it on GitHub https://github.com/Growstuff/growstuff/issues/556#issuecomment-133316320 .
Is it worth us spinning off a separate issue for them and locking down the design so we can get them added, then?
On 21 August 2015 at 13:00, Mackenzie [email protected] wrote:
Technically, we could have had share buttons ages ago. They can be done without the API.
On Fri, Aug 21, 2015, 3:38 AM Cesy [email protected] wrote:
I think probably we don't want to read location - better to give members the choice of how granular to specify it for Growstuff separately. Reading photos is a nice feature for the long-term, as it will make adding photos to gardens much easier, but not necessary for MVP. Part of the aim of this eventually is to be able to write - adding optional "Share to Facebook" and "Share to Twitter" buttons whenever you plant or harvest something, and so on.
— Reply to this email directly or view it on GitHub < https://github.com/Growstuff/growstuff/issues/556#issuecomment-133316320>
.
— Reply to this email directly or view it on GitHub https://github.com/Growstuff/growstuff/issues/556#issuecomment-133390240 .
I think it might be. Interestingly, now that #733 is "sorta working", we can probably implement this with plain links by simply rendering an appropriate og:image attribute whenever we have a more accurate picture, and populating an og:title (should already work if there's content_for :title)
After #811 is bedded down, I'll pick this up and look at UI for 'connect facebook account' - should be fairly straight forward given the existing implementations.
This should work now, as part of #811 - from the 'apps' member page, you can connect. There's something odd on my local around the routes which is absent in staging, so it'll need testing there + the credential setup... but yeah; should be closable shortly