ArsMagica2 icon indicating copy to clipboard operation
ArsMagica2 copied to clipboard

Crash when using the inscription table

Open Shahhubminecraft opened this issue 7 years ago • 16 comments

i am using 1.10.2 and ars magica2 version: 17b here is the crash report:http://pastebin.com/zyAgw7kQ

Shahhubminecraft avatar Mar 04 '17 20:03 Shahhubminecraft

did you do anything to cause this to happen? other than just opening the table i mean.

Growlith1223 avatar Mar 05 '17 07:03 Growlith1223

OptiFine Version: OptiFine_1.10.2_HD_U_D6

Does the crash still occur without Optifine?

TheIcyOne avatar Mar 05 '17 12:03 TheIcyOne

it is when i am crafting a spell and yes it does crash without optifine

Shahhubminecraft avatar Mar 05 '17 18:03 Shahhubminecraft

what spell exactly?

Growlith1223 avatar Mar 05 '17 19:03 Growlith1223

Also happened to me, hovewer i ignored it. I wanted to create speel like this: Shapes: Projectile Modifier: Leap And it suddenly crashed. Book was inserted into the table, crash occured just before i moved the mouse to name the spell. If it happens again, i might post the crash log

CyprinusCarpio avatar Mar 05 '17 20:03 CyprinusCarpio

Happend to me too. Spell Self + Heal, Was trying to find out, how the table woks, Drag the self to the brown part of the Table and clicked on the empty grey field on the bottom. Was not reproducable after restart. No Optifine. Modpack All the mods 1.10.2

DietmarKrause avatar Mar 06 '17 08:03 DietmarKrause

Your client should save the crash log in a folder if you can access the files. It would be greatly appreciated if you could post them in a pastebin link.

xenxero1 avatar Mar 06 '17 13:03 xenxero1

There's a multithreading bug in server handling of inscription table which cause client to crash, see #274 .

LemADEC avatar Mar 09 '17 23:03 LemADEC

Successfully crafted 2 spells but the third is having issues when I leave the table open more than a few seconds (it does not matter whether I have anything configured in the table). If it matters I just unlocked magic damage, fire damage, and shrink. Constructing a new Inscription Table does not help. Adding tier upgrades do give me the 3rd, 4th, 5th slots, but it still crashes. ` if(groupIndex > this.shapeGroups.size() || groupIndex < 0)

Does not catch any case where (groupIndex == this.shapeGroups.size()), which would overflow the array on any groupIndex > 0 or try to access an empty array on groupIndex ==0 groupIndex >= this.shapeGroups.size() would be a quick fix but not address the underlying ConcurrentModificationException on the server side. http://pastebin.com/Sz75kxbL

psath avatar Mar 14 '17 02:03 psath

A fresh build with the above check switched to greater-than-or-equals resolves it for me. (Though it does nothing to fix the multithreading bug). There is a little stutter in the GUI every now and then, but spells are craftable and the client no longer crashes.

psath avatar Mar 14 '17 05:03 psath

Geez, talk about a thorough smoke test!

xenxero1 avatar Mar 15 '17 15:03 xenxero1

That's one of the advantages of more and more mods going open source. Rather than the typical "it doesn't work, wahh" bug report, motivated users with some experience can try to help, or at the very least provide better diagnostics.

psath avatar Mar 15 '17 16:03 psath

If you're not already, consider looking into a job as a QA Tester. Pretty decent pay and you've already got the informal training for it! Depending on your area, I've heard Comcast is hiring for their teams.

xenxero1 avatar Mar 15 '17 16:03 xenxero1

Do you need more info on this crash? I've recently set up a new 1.10.2 server and we are experiencing the inscription table crash. It does seem to be a timing issue. In order to use it we start the interaction and do as much as we can as quick as we can before it crashes. Then restart the client and repeat until we get through the spell construction process and remove the book. Let me know if you would like a crash or log report.

Thanks for updating this to 1.10.2, This is my favorite mod so I build my servers based on this mod and Tconstruct. I miss Thaumcraft though:-)

Prazoot avatar Mar 21 '17 19:03 Prazoot

@Prazoot what version would you happen to be using? -17 or -17b?

xenxero1 avatar Mar 21 '17 19:03 xenxero1

Sorry I should have included that. I'm using -17b. I'ld be more than happy to test out any fixes if you need. I set up a Ubuntu server with several mods (roughly 21mods).

Prazoot avatar Mar 22 '17 19:03 Prazoot