3rd_training_lua
3rd_training_lua copied to clipboard
Published
20 hours ago •
Grouflon
Grouflon
Support for ssf2xjr1
Hello, following #43 , I’m opening this to talk about adding support for ssf2xjr1 rom to the tool, and ask questions I have.
As I explained for starters I am trying to make the input display work.
It works a bit with the attached patch draft.patch.txt
So, questions:
- What do you think of the organisation with a roms.lua file containing the rom specific information?
- What about rom specific code, for now I put it in the same file because there is only one function but it will be a mess quite soon if we do it like this I think. We should find a nice way to split each rom specific code in a file, and not mix rom information and rom specific code.
- When should is_in_match be true? I read an address that differs from 0 only when the players have character control, meaning it becomes true after the «fight!» title, and it goes back to false in between rounds, is that ok?
- How were the framedata json file built? Was that recorded with another script? Which features require this framedata?
- Is there anything special to know about the character select snapshot or is it just a snapshot of the character select screen of a fresh game? Should both player have pressed start before the snapshot?
We should probably set up a call on discord to at least kick off all those discussions don't you think ? do you have a discord id ?
We should probably set up a call on discord to at least kick off all those discussions don't you think ? do you have a discord id ?
MCMic#5229 but I can’t have a call today, or maybe late after 9h30 pm.
