3rd_training_lua icon indicating copy to clipboard operation
3rd_training_lua copied to clipboard

[Feature] Add "after first hit" blocking mode

Open deeebug opened this issue 4 years ago • 3 comments

Feel free to change or request anything for the merge.

deeebug avatar Jan 13 '21 18:01 deeebug

Hey, I finally got the time to test your branch, thanks again for contributing :). I don't know if I got it correctly, but I think that the behavior is not really what I had in mind with this feature. For me it should block the first blockstring, and as soon as the blockstring ends, it should stop blocking until the next hit or some time pass without anything happening. If I understand the code correctly, what you wrote will make the dummy block until 90 frames pass with the dummy not having any hit or block. Can you tell me a little bit more about what you think ?

Grouflon avatar Jan 19 '21 19:01 Grouflon

Well, I intended this mode to be where you could test true combo strings. First hit would be let in and anything following that shouldn't work until 90 frames. Of course, if it's a true combo string the consecutive hits would work, otherwise anything will be blocked. Hence, "after first hit".

By the way, didn't notice that you had an issue up for a block mode with a similar name until a PR was sent. But, isn't this what you wrote in that issue? Or maybe it's not working that way, somehow?

deeebug avatar Jan 21 '21 19:01 deeebug

Hello! :D

I have tested the feature and works fine, but I think this code could be more clear and DRY.

Is this PR going to be merged? I also have a woking version that can be used :D

alepaez avatar Sep 13 '21 22:09 alepaez