GrosSacASacs

Should I delete v3 tag on npm and replace it with next ?

@tunnckoCore are you ok if I mark v3 as latest now ?

Converting to Typescript is already a huge task. You refactoring the code at the same time reduces the likelihood of this PR being merged fast. Because it creates opportunity for...

- Correct , https://github.com/node-formidable/formidable/blob/64f32c2d5486918b2b8afdc2c6cc994d5f9a4a61/src/Formidable.js#L442 add this line back - A plugin does not really return , instead it attaches properties to the formidable instance (this._parser = parser;)

I don't know where but if it is always true then maybe it is a leftover from before a refactor where it wasn't the case

Maybe in a future PR we will make .parse return a Promise so try to not change too much in this PR

PR welcome :) It depends on what features you used. The interface of certain objects has changed.

@KennanChan Use a variable that is closed over ```js let finalFilename; const form = formidable({ fileWriteStreamHandler: (/* file */) => { // use variable finalFilename here return writable; }, });...

That is good point, and the readme could definitely have a small guide on how to check this. I don't think we will ever bake in content-based MIME detection since...

> multer detects file's MIME not by the extension only. How does multer do it ?