Stalker_GAMMA icon indicating copy to clipboard operation
Stalker_GAMMA copied to clipboard

Possible bad input variable for Actor Damage Balancer for Elemental Damage

Open ilrathCXV opened this issue 8 months ago • 1 comments

Within the grok_actor_damage_balancer.script, the function elemental_damage(draftman_sec, shit, bone_id, flags) appears to be passing in the wrong variable for the draftman_sec when called. When this function is called (lines 934, 939, 944, and 949), it passes in shit.draftsman:id() instead of shit.draftsman:section(), causing the string.find calls to always return false as we are passing in its ID number instead of its actual section.

I wanted to know if this was done intentionally due to balance reasons or was a mistake.

For clarification, in the lines mentioned above, (if this is a mistake) they should be changed from: elemental_damage(shit.draftsman:id(), shit, bone_id, flags) ...to: elemental_damage(shit.draftsman:section(), shit, bone_id, flags)

ilrathCXV avatar Apr 21 '25 02:04 ilrathCXV

I think it's an error which would explain some inconsistencies with elemental damages. Thanks for checking that out, good catch. I'll verify it and push a patch.

Grokitach avatar Apr 21 '25 06:04 Grokitach

Thanks a lot for pointing that out, fixed in https://github.com/Grokitach/Stalker_GAMMA/commit/141660c2ff7d08b559a2149e7d97ecbb6963abb1

Grokitach avatar Jun 25 '25 19:06 Grokitach