TemplePlus icon indicating copy to clipboard operation
TemplePlus copied to clipboard

PySpells not getting cleaned up when script has errors

Open DudeMcDude opened this issue 3 years ago • 1 comments

I did get another crash that might be related. It was shortly after loading, so I tried reproducing it but couldn't. The crash happened when casting web on a dozen guys in the temple back door fight (which of course plays a lot of overlapping sounds, although the crash seemed to occur before any sound). I could upload a save, but I imagine it wouldn't be very useful.

The behavior seems like some kind of race condition, I guess probably in the sound system given what you mentioned before.

Originally posted by @dolio in https://github.com/GrognardsFromHell/TemplePlus/issues/606#issuecomment-917715667

DudeMcDude avatar Aug 07 '22 21:08 DudeMcDude

And it did have something to do with the script error in the Silence spell - due to this error the PySpell was not disposed of correctly, and carried over when loading the save. 100% reproducible.

Thanks @dolio, took me a while but I got there :)

Not sure yet if it's related to the first report in #606.

DudeMcDude avatar Aug 07 '22 21:08 DudeMcDude