TemplePlus icon indicating copy to clipboard operation
TemplePlus copied to clipboard

Vigor fixes

Open Sagenlicht opened this issue 4 years ago • 4 comments

In my recent playthrough I used the vigor spells from Co8 the first time. The Lesser Vigor (I didn't test other ones) spell did corrupt my save files. If I cast the spell on a party member, save the game while the spell is active, and loading the save afterwards leads to a game crash, making the save unusable. I can reproduce this behaviour.

Testing was done outside of combat, on different party members and in different locations. All tests did leave to corrupted save files.

I wanted to do the mass versions as part of the Spell Compendium anyways (the normal Vigor spells are part of the SC as well) so I redid the three single target spells as well as adding the new ones. They all use the same condition (sp-vigor_fast_healing), all spells only pass their fast healing amount to the condition.

Bonus side effects:

  • You can't stack different vigor spells anymore (which you shouldn't be able to do), only the highest fast healing effect will stick.
  • I added help file entries for all three existing Co8 Vigor spells as well as the two new ones
  • Vigor spells are now hyperlinked to help files in the History Window
  • All Vigor spells now have a new particle effect
  • All Vigor spells have a Vigor buff icon now
  • Buff icons shows correct duration
  • The Co8 spells now have a spell long description

Cons: I have never replaced an existing spell from Co8. So I hope I did it the correct way.

  • I removed the Spell794 - Lesser Vigor.py as well as the other 2 scripts from Co8infra and did regenerate that file
  • I added the spells to my spell_compendium admin files with the exception of the sound file. Though I am unsure if you can actually use Temple+ without Co8. If not, not all admin file entries would be needed

Edit: These spells require my updated spell_utils

Sagenlicht avatar Dec 30 '21 20:12 Sagenlicht

Cool stuff!

DudeMcDude avatar Jan 01 '22 09:01 DudeMcDude

Removed the onRemove heal sum up again, it triggers on too many occasions that it's not worth to add the missing ticks on a rest trigger. @anatoliy-savchak What did you comment why on? That I limited the history output to combat only or on the sum up?

Sagenlicht avatar Jan 12 '22 11:01 Sagenlicht

Yes @Sagenlicht. As a Player I want to have all logs at least in some place. History pane should have as much as it can IMHO. But it's up to you.

Moreover being DM I always ask Players to show me heal wand dice rolls and account wand leftover. So personally I would love to see any healing rolls in my History pane.

anatoliy-savchak avatar Jan 12 '22 11:01 anatoliy-savchak

Yes @Sagenlicht. As a Player I want to have all logs at least in some place. History pane should have as much as it can IMHO. But it's up to you.

I am unsure about this myself. I am a huge fan of verbosing the history myself, but Vigor ticks alot, Inside combat this is no problem, I agree, information is key there, but outside of combat it appeared a little bit spammy to me while I playtested Vigor in my current runthrough.

In addition I am not sure how confusing the new behaviour now actually is, when the history output suddenly stops...

Sagenlicht avatar Jan 14 '22 11:01 Sagenlicht