Griddle icon indicating copy to clipboard operation
Griddle copied to clipboard

update dependency versions

Open aaronsmulktis opened this issue 2 years ago • 3 comments

Griddle major version

1.14.0

Changes proposed in this pull request

Modify package.json & package-lock.json

Why these changes are made

Upgrading packages addressing critical security vulnerabilities

Are there tests?

No

aaronsmulktis avatar Oct 22 '22 02:10 aaronsmulktis

This looks great! Thank you for adding it!

I'm wondering if you're seeing this same thing that I am locally on running the start script

ERR! TypeError: Cannot read properties of undefined (reading 'module')
ERR!     at module.exports (~/projects/javascript/Griddle/.storybook/webpack.config.js:3:10)

ryanlanciaux avatar Oct 22 '22 19:10 ryanlanciaux

Yep @ryanlanciaux, sorry meant to save this as a draft. I also saw a few tests failing.

Still working on this! Will update soon...

aaronsmulktis avatar Oct 23 '22 12:10 aaronsmulktis

Haha, no worries - wanted to make sure I wasn't missing something

ryanlanciaux avatar Oct 23 '22 19:10 ryanlanciaux