Griddle icon indicating copy to clipboard operation
Griddle copied to clipboard

Settings show even when it is "false"

Open buildWithSoul opened this issue 6 years ago • 2 comments

Griddle version

latest version of griddle-react- followed steps listed on site

Expected Behavior

settings should not show, when settings={false} is passed in

Actual Behavior

settings shows regardless of whether boolean is passed in

Steps to reproduce

tested with simple Griddle component and data- settings still shows

Pull request with failing test or storybook story with issue

While this step is not necessary, a failing test(s) and/or a storybook story will help us resolve the issue much more easily. Please see the README for more information.

buildWithSoul avatar Jun 01 '18 02:06 buildWithSoul

Current workaround- passing in style config and set display to none for settings and settingstoggle

buildWithSoul avatar Jun 01 '18 02:06 buildWithSoul

Try enableSettings={false}.

dahlbyk avatar Jun 01 '18 03:06 dahlbyk