Griddle icon indicating copy to clipboard operation
Griddle copied to clipboard

React 16

Open ryanlanciaux opened this issue 8 years ago • 9 comments

Griddle version

1.x

Expected Behavior

Griddle's storybook works with React 16

Actual Behavior

Griddle may be working but may have some things in some of the stories that are using deprecated features (this very well could be Griddle also).

Steps to reproduce

yarn add [email protected]
yarn add [email protected]

Pull request with failing test or storybook story with issue

No failing test.

ryanlanciaux avatar Sep 07 '17 14:09 ryanlanciaux

Please update also to recompose ^0.25.1, which supports React ^16.0.0 🙂

MichaelDeBoey avatar Oct 18 '17 10:10 MichaelDeBoey

@ryanlanciaux Any news on this one? 🙂

MichaelDeBoey avatar Oct 24 '17 10:10 MichaelDeBoey

https://github.com/GriddleGriddle/Griddle/pull/765/commits/c8b6d16ebd3fcaa71aeac97014a2ce5e0f3d7e4e pinned to [email protected]. Apparently there's a fix for v15 (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/21233), or we can address this only for v16.

dahlbyk avatar Nov 06 '17 21:11 dahlbyk

@ryanlanciaux Any news on this one? 🙂

CC: @dahlbyk @joellanciaux

MichaelDeBoey avatar Dec 06 '17 13:12 MichaelDeBoey

@ryanlanciaux Any news on this one? 🙂

CC: @dahlbyk @joellanciaux

MichaelDeBoey avatar Jan 11 '18 10:01 MichaelDeBoey

Any news? recompose needs to be updated... thanks

bouzafr avatar Jan 24 '18 01:01 bouzafr

I hope to address updating some of the dependencies early next week (unless someone beats me to it 👍 ) and would love to have a better strategy for managing them moving forward.

ryanlanciaux avatar Jan 24 '18 01:01 ryanlanciaux

Any update?

andychongyz avatar Jul 02 '18 10:07 andychongyz

Added a small PR upgrading recompose: https://github.com/GriddleGriddle/Griddle/pull/839

mDibyo avatar Nov 05 '18 03:11 mDibyo