Griddle icon indicating copy to clipboard operation
Griddle copied to clipboard

Published 20 hours ago • verified publisher icon GriddleGriddle

Hover plugin

Open yoursdearboy opened this issue 8 years ago • 5 comments

Griddle major version

1.3.0

Changes proposed in this pull request

Added a plugin that provide each Cell with hoveredRowKey property which is equal to griddleKey of hovered row.

Why these changes are made

Don't know if this repo is a proper place to contribute plugins (at least I see plugins directory). We use it to show toolbar for records in rows (see storybook demo).

Are there tests?

Storybook story only.

yoursdearboy avatar Apr 11 '17 13:04 yoursdearboy

@dahlbyk Any news on merging this one?

MichaelDeBoey avatar Dec 13 '17 15:12 MichaelDeBoey

@yoursdearboy Any news on addressing @dahlbyk's comments? 🙂

MichaelDeBoey avatar Dec 20 '17 15:12 MichaelDeBoey

@MichaelDeBoey honestly, I would just copy the relevant bits into your own plugin. There's not all that much to wiring up Row events.

dahlbyk avatar Dec 20 '17 20:12 dahlbyk

@dahlbyk Yeah I had a few problems doing so, so was hoping the plugin could help 😕

Will try and make some issues together with a codesandbox, so you could maybe point me in the right direction if you want 🙂

MichaelDeBoey avatar Dec 20 '17 20:12 MichaelDeBoey

Glad to help as time allows

dahlbyk avatar Dec 23 '17 05:12 dahlbyk