gown.js icon indicating copy to clipboard operation
gown.js copied to clipboard

labelFont and labelColor in theme

Open marfri opened this issue 8 years ago • 1 comments

What do they do? Why is labelFont, labelColor and textStyle used in buttons for the label? Does seem a bit redundant and error prone, since labelFont and labelColor are used to set updateLabel, but textStyle is used to update the style.

marfri avatar Nov 07 '16 07:11 marfri

You are right, this is a source of future bugs! I added textStyle as an alternative to change text properties (especially text size) without the need of creating/copying an whole theme for just that. I think TextStyle could use some flag/function to notify if the text properties have been changed. Also I am not sure if we need to keep ThemeFont (font for text in pixi v4 is deprecated, they use fontSize and fontFamily directly now, so a normal JavaScript-Object should be enough)

brean avatar Nov 07 '16 08:11 brean