greptimedb icon indicating copy to clipboard operation
greptimedb copied to clipboard

Duplicated definition of Values

Open v0y4g3r opened this issue 2 years ago • 1 comments

What type of bug is this?

Other

What subsystems are affected?

Other

What happened?

Seems there're two identical definitions for Values

https://github.com/GreptimeTeam/greptimedb/blob/74ea529d1a409551394ad457ce6d571e238c774a/src/storage/proto/write_batch.proto#L67-L85

https://github.com/GreptimeTeam/greptimedb/blob/c1b8981f61873a4b4466184e59901566177ce7e9/src/api/greptime/v1/column.proto#L15-L36

Not sure if it's intentional, but better refactor these into one proto.

What operating system did you use?

NA

Relevant log output and stack trace

NA

How can we reproduce the bug?

NA

v0y4g3r avatar Dec 09 '22 06:12 v0y4g3r

I think we could use greptimedb/src/api/greptime/v1/column.proto, but actually we use arrow's IPC format as write batch's default format instead of protobuf.

evenyag avatar Dec 16 '22 02:12 evenyag

Already resolved. Only keeps column.proto.

killme2008 avatar Jun 20 '23 10:06 killme2008