greptimedb icon indicating copy to clipboard operation
greptimedb copied to clipboard

feat: support multi regions on datanode

Open v0y4g3r opened this issue 2 years ago • 1 comments

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Support mutliple regions on datanode.

Checklist

  • [X] I have written the necessary rustdoc comments.
  • [ ] I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Fixes #625

v0y4g3r avatar Nov 29 '22 07:11 v0y4g3r

This feature requires refactor gRPC services using Arrow Flight.

v0y4g3r avatar Dec 09 '22 08:12 v0y4g3r

Codecov Report

Merging #653 (df6a78a) into develop (b0925d9) will decrease coverage by 0.14%. The diff coverage is 87.01%.

@@             Coverage Diff             @@
##           develop     #653      +/-   ##
===========================================
- Coverage    85.88%   85.75%   -0.14%     
===========================================
  Files          443      443              
  Lines        59202    59292      +90     
===========================================
- Hits         50848    50846       -2     
- Misses        8354     8446      +92     
Flag Coverage Δ
rust 85.75% <87.01%> (-0.14%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/catalog/src/lib.rs 85.89% <0.00%> (-2.72%) :arrow_down:
src/catalog/src/local/manager.rs 69.77% <ø> (+0.17%) :arrow_up:
src/catalog/src/remote/manager.rs 68.13% <ø> (+0.11%) :arrow_up:
src/mito/src/error.rs 70.96% <0.00%> (-4.90%) :arrow_down:
src/partition/src/error.rs 0.00% <ø> (ø)
src/table/src/error.rs 87.87% <0.00%> (-1.36%) :arrow_down:
src/table/src/requests.rs 66.66% <ø> (ø)
src/mito/src/table.rs 88.60% <82.05%> (-3.02%) :arrow_down:
src/mito/src/engine.rs 98.38% <92.23%> (-0.53%) :arrow_down:
src/frontend/src/table.rs 94.08% <92.85%> (-0.07%) :arrow_down:
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jan 31 '23 07:01 codecov[bot]

seems this PR contains the changes in https://github.com/GreptimeTeam/greptimedb/pull/906 ?

MichaelScofield avatar Feb 01 '23 03:02 MichaelScofield

seems this PR contains the changes in #906 ?

Maybe I should get #906 merged first to reduce size of this PR.

v0y4g3r avatar Feb 01 '23 11:02 v0y4g3r

We need to find a way to pass region filters to datanode through substrait plans so that we don't have to iterate all regions on some datanode.

Can we create an issue to track this?

killme2008 avatar Feb 01 '23 11:02 killme2008

We need to find a way to pass region filters to datanode through substrait plans so that we don't have to iterate all regions on some datanode.

Can we create an issue to track this?

I created #926

v0y4g3r avatar Feb 01 '23 11:02 v0y4g3r