greptimedb icon indicating copy to clipboard operation
greptimedb copied to clipboard

fix: start datanode instance before frontend services

Open v0y4g3r opened this issue 2 years ago • 1 comments

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • Break datanode startup process into "start components" and "start services"
  • When running in standalone mode, start datanode components before frontend services, to avoid receiving request under a initializing state,

Checklist

  • [X] I have written the necessary rustdoc comments.
  • [ ] I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

v0y4g3r avatar Nov 24 '22 15:11 v0y4g3r

Codecov Report

Merging #634 (b95bffe) into develop (051768b) will decrease coverage by 0.01%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #634      +/-   ##
===========================================
- Coverage    86.46%   86.44%   -0.02%     
===========================================
  Files          402      402              
  Lines        50928    50938      +10     
===========================================
+ Hits         44033    44034       +1     
- Misses        6895     6904       +9     
Flag Coverage Δ
rust 86.44% <0.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/cmd/src/standalone.rs 38.42% <0.00%> (-1.04%) :arrow_down:
src/datanode/src/datanode.rs 47.72% <0.00%> (-6.12%) :arrow_down:
src/meta-srv/src/service/heartbeat.rs 87.36% <0.00%> (+1.05%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Nov 24 '22 15:11 codecov[bot]