greptimedb icon indicating copy to clipboard operation
greptimedb copied to clipboard

chore: able to config axum timeout in toml (#463)

Open dongxuwang opened this issue 2 years ago • 2 comments

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • Use toml configured timeout instead of hard code
  • Add one more timeout together with http_addr to build a HttpOptions struct

Checklist

  • [x] I have written the necessary rustdoc comments.
  • [x] I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

(#463)

dongxuwang avatar Nov 18 '22 12:11 dongxuwang

Codecov Report

Merging #579 (f4c104b) into develop (7b37e99) will increase coverage by 0.01%. The diff coverage is 87.75%.

@@             Coverage Diff             @@
##           develop     #579      +/-   ##
===========================================
+ Coverage    86.28%   86.30%   +0.01%     
===========================================
  Files          402      402              
  Lines        50973    51058      +85     
===========================================
+ Hits         43983    44066      +83     
- Misses        6990     6992       +2     
Flag Coverage Δ
rust 86.30% <87.75%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/server.rs 0.00% <0.00%> (ø)
src/cmd/src/standalone.rs 39.45% <64.28%> (+1.74%) :arrow_up:
src/servers/src/http.rs 82.08% <91.48%> (+1.33%) :arrow_up:
src/cmd/src/frontend.rs 73.46% <100.00%> (+7.95%) :arrow_up:
src/frontend/src/frontend.rs 51.42% <100.00%> (+2.85%) :arrow_up:
src/servers/src/error.rs 35.13% <0.00%> (+8.10%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Nov 18 '22 13:11 codecov[bot]

Thanks, @dongxuwang ! I have tracked this PR in issue #463 , though GitHub only allows adding issue participants to assignees. I'd review this in the next few days.

evenyag avatar Nov 18 '22 15:11 evenyag