greptimedb icon indicating copy to clipboard operation
greptimedb copied to clipboard

fix: correctly open table when distributed datanode restart

Open MichaelScofield opened this issue 2 years ago • 2 comments

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

fix #402

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  1. correctly open table when distributed datanode restart
  2. concat node_id in data dir and wal dir of datanode, when it is started in distributed mode
  3. upgrade opensrv-mysql to latest version 0.2

Checklist

  • [] I have written the necessary rustdoc comments.
  • [] I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

MichaelScofield avatar Nov 18 '22 10:11 MichaelScofield

Codecov Report

Merging #576 (aae5624) into develop (ca5734e) will decrease coverage by 0.03%. The diff coverage is 67.13%.

@@             Coverage Diff             @@
##           develop     #576      +/-   ##
===========================================
- Coverage    86.45%   86.41%   -0.04%     
===========================================
  Files          399      400       +1     
  Lines        50649    50675      +26     
===========================================
+ Hits         43788    43793       +5     
- Misses        6861     6882      +21     
Flag Coverage Δ
rust 86.41% <67.13%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/api/src/error.rs 35.71% <0.00%> (-5.96%) :arrow_down:
src/api/src/lib.rs 100.00% <ø> (ø)
src/catalog/src/local/manager.rs 66.36% <0.00%> (-0.21%) :arrow_down:
src/catalog/src/remote/manager.rs 70.04% <0.00%> (-0.47%) :arrow_down:
src/datanode/src/error.rs 62.19% <0.00%> (-0.77%) :arrow_down:
src/frontend/src/error.rs 9.25% <0.00%> (-0.36%) :arrow_down:
src/query/src/optimizer.rs 79.59% <ø> (-0.33%) :arrow_down:
src/table/src/requests.rs 25.00% <ø> (ø)
src/servers/src/mysql/writer.rs 70.76% <42.85%> (-5.30%) :arrow_down:
src/servers/src/mysql/handler.rs 68.04% <44.44%> (+2.82%) :arrow_up:
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Nov 18 '22 11:11 codecov[bot]

@killme2008 PTAL

MichaelScofield avatar Nov 19 '22 12:11 MichaelScofield

@killme2008 PTAL

MichaelScofield avatar Nov 20 '22 03:11 MichaelScofield

@v0y4g3r PTAL

MichaelScofield avatar Nov 21 '22 05:11 MichaelScofield