greptimedb icon indicating copy to clipboard operation
greptimedb copied to clipboard

feat: impl alter table in distributed mode

Open v0y4g3r opened this issue 2 years ago • 1 comments

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • Implement alter table in distributed mode
  • Rename common/insert crate to common/gprc-expr
  • Move some gRPC struct to request convesion functions to common/gprc-expr

Checklist

  • [X] I have written the necessary rustdoc comments.
  • [X] I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

NA

v0y4g3r avatar Nov 18 '22 08:11 v0y4g3r

Codecov Report

Merging #572 (2e82356) into develop (62fcb54) will decrease coverage by 0.07%. The diff coverage is 73.30%.

@@             Coverage Diff             @@
##           develop     #572      +/-   ##
===========================================
- Coverage    86.41%   86.34%   -0.08%     
===========================================
  Files          400      401       +1     
  Lines        50671    50769      +98     
===========================================
+ Hits         43788    43836      +48     
- Misses        6883     6933      +50     
Flag Coverage Δ
rust 86.34% <73.30%> (-0.08%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/api/src/lib.rs 100.00% <ø> (ø)
src/api/src/v1/column_def.rs 100.00% <ø> (ø)
src/client/src/database.rs 75.10% <ø> (ø)
src/client/src/error.rs 0.00% <ø> (ø)
src/common/grpc-expr/src/error.rs 5.26% <0.00%> (ø)
src/datanode/src/error.rs 63.41% <0.00%> (+1.21%) :arrow_up:
src/frontend/src/error.rs 8.92% <0.00%> (-0.34%) :arrow_down:
src/frontend/src/instance/distributed.rs 78.15% <0.00%> (-6.14%) :arrow_down:
src/frontend/src/instance/influxdb.rs 0.00% <0.00%> (ø)
src/frontend/src/table.rs 89.92% <0.00%> (-2.18%) :arrow_down:
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Nov 19 '22 08:11 codecov[bot]

Could you please resolve the conflict first?

evenyag avatar Nov 21 '22 06:11 evenyag