greptimedb icon indicating copy to clipboard operation
greptimedb copied to clipboard

feat: implement DESCRIBE TABLE

Open morigs opened this issue 2 years ago • 2 comments

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Support DESC[RIBE] TABLE sql clause. Returns following info about table columns: name, type, nullable, default, semantic type.

Not sure about Display for Value implementation. Perhaps it should be more sql-ish

Checklist

  • [x] I have written the necessary rustdoc comments.
  • [x] I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Resolves #534

morigs avatar Nov 17 '22 10:11 morigs

Codecov Report

Merging #558 (232b816) into develop (8faa6b0) will increase coverage by 0.06%. The diff coverage is 93.75%.

@@             Coverage Diff             @@
##           develop     #558      +/-   ##
===========================================
+ Coverage    86.38%   86.44%   +0.06%     
===========================================
  Files          398      399       +1     
  Lines        50042    50610     +568     
===========================================
+ Hits         43229    43752     +523     
- Misses        6813     6858      +45     
Flag Coverage Δ
rust 86.44% <93.75%> (+0.06%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/datanode/src/instance/sql.rs 86.58% <0.00%> (-4.45%) :arrow_down:
src/datanode/src/sql.rs 73.50% <0.00%> (-0.99%) :arrow_down:
src/frontend/src/instance.rs 73.31% <0.00%> (ø)
src/frontend/src/instance/distributed.rs 83.98% <0.00%> (+0.07%) :arrow_up:
src/query/src/datafusion/planner.rs 82.22% <ø> (ø)
src/query/src/error.rs 24.00% <0.00%> (+24.00%) :arrow_up:
src/sql/src/statements.rs 80.62% <ø> (ø)
src/sql/src/statements/statement.rs 48.27% <0.00%> (-5.58%) :arrow_down:
src/datatypes/src/schema/constraint.rs 97.38% <80.00%> (-0.47%) :arrow_down:
src/sql/src/parser.rs 71.69% <86.20%> (+1.78%) :arrow_up:
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Nov 17 '22 10:11 codecov[bot]

Thanks for the feedback. I'll fix this soon

morigs avatar Nov 17 '22 12:11 morigs

Thanks for the feedback. I'll fix this soon

Currently I'm Ok with the catalog/schema name issue and marked these are resolved. Please fix other comments and we can merge this PR as soon as possible. Don't hesitate to reach us if you need any help!

v0y4g3r avatar Nov 18 '22 06:11 v0y4g3r