greptimedb icon indicating copy to clipboard operation
greptimedb copied to clipboard

fix: avoid unused_variables under Windows

Open waynexia opened this issue 1 year ago • 2 comments

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Fixes https://github.com/GreptimeTeam/greptimedb/actions/runs/8808344307

What's changed and what's your intention?

image

Checklist

  • [ ] I have written the necessary rustdoc comments.
  • [ ] I have added the necessary unit tests and integration tests.
  • [x] This PR does not require documentation updates.

waynexia avatar Apr 24 '24 02:04 waynexia

Test pipeline against this branch: https://github.com/GreptimeTeam/greptimedb/actions/runs/8810252748

waynexia avatar Apr 24 '24 02:04 waynexia

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.57%. Comparing base (f764fd5) to head (acd4b25). Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3786      +/-   ##
==========================================
+ Coverage   85.52%   85.57%   +0.04%     
==========================================
  Files         946      946              
  Lines      159621   159929     +308     
==========================================
+ Hits       136511   136852     +341     
+ Misses      23110    23077      -33     

codecov[bot] avatar Apr 24 '24 02:04 codecov[bot]

@waynexia can we move forward this draft? I don't see anything pending here :O

tisonkun avatar Apr 28 '24 03:04 tisonkun