greptimedb icon indicating copy to clipboard operation
greptimedb copied to clipboard

Rewrite the UDF implementation under the new DataFusion

Open MichaelScofield opened this issue 10 months ago • 0 comments

What type of enhancement is this?

Other

What does the enhancement do?

The new DataFusion deprecates how its UDF can be written before, specifically the ScalarUDF::new:

impl ScalarUDF {
    /// Create a new ScalarUDF from low level details.
    ///
    /// See  [`ScalarUDFImpl`] for a more convenient way to create a
    /// `ScalarUDF` using trait objects
    #[deprecated(since = "34.0.0", note = "please implement ScalarUDFImpl instead")]
    pub fn new(
        name: &str,
        signature: &Signature,
        return_type: &ReturnTypeFunction,
        fun: &ScalarFunctionImplementation,
    ) -> Self {

We should use the new implementation once https://github.com/GreptimeTeam/greptimedb/pull/3661 is merged.

Implementation challenges

No response

MichaelScofield avatar Apr 08 '24 09:04 MichaelScofield