greptimedb
greptimedb copied to clipboard
Migrates more tests from duckdb
What type of enhancement is this?
Tech debt reduction, Other
What does the enhancement do?
We already migrate some tests from duckdb's SQL test: https://github.com/duckdb/duckdb/tree/master/test/sql. And it already helps us figure out some bugs such as #790 #791 #759 etc.
But there are still many tests that still need to be migrated. Let's create an issue to track them:
- [x] join
- [ ] select @Gump9
- [ ] subquery
- [ ] tpch
- [ ] copy
- [ ] prepared
- [ ] parser
- [ ] insert (specifically, "insert ... select")
- [ ] types
I list the main tests. Of course, our current tests still miss many cases; they must also be migrated.
Implementation challenges
No response
Could we introduce the Sqllogictest-rs framework to perform tests?
We already have sqlness https://docs.greptime.com/developer-guide/tests/sqlness-test
We already have sqlness https://docs.greptime.com/developer-guide/tests/sqlness-test
I see. I thought we could utilize the existing sqllogictest test files, but we still need to modify them.
Hello!I'm new to here.Can I have a try to migrate select tests?What test cases can I refer to that have been migrated? where are they?
@Gump9 welcome! The test cases for select are here
@Gump9 welcome! The test cases for select are here
Excuse me again, could you tell me where are the tests that have been migrated to gretimeDB,i notice that the join part has been migrated,and how can i learn this part in greptimeDB.sry,i'm really new and unfamiliar with many things😭
@Gump9 We are expecting the duckdb's test cases, the SQLs, to be ported into our sqlness tests. To start, you can learn everything about sqlness tests here. Then you can check the duckdb's test cases, to see if the SQL is already present in our sqlness tests. If not, just add that case to our sqlness tests.