ExRam.Gremlinq icon indicating copy to clipboard operation
ExRam.Gremlinq copied to clipboard

Implemented a test for fantomly typed value object

Open xperiandri opened this issue 1 year ago • 7 comments

@danielcweber this test succeeds while using struct in production it fails

xperiandri avatar Jan 19 '24 14:01 xperiandri

So...is this CI run supposed to fail or not?

danielcweber avatar Jan 19 '24 15:01 danielcweber

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (23195cf) 79.18% compared to head (37ad104) 79.18%. Report is 28 commits behind head on 12.x.

:exclamation: Current head 37ad104 differs from pull request most recent head 78b8be8. Consider uploading reports for the commit 78b8be8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             12.x    #1458   +/-   ##
=======================================
  Coverage   79.18%   79.18%           
=======================================
  Files         250      250           
  Lines        6967     6967           
  Branches     1659     1659           
=======================================
  Hits         5517     5517           
  Misses        699      699           
  Partials      751      751           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 19 '24 15:01 codecov[bot]

@xperiandri I have still no way of reproducing any kind of failure.

danielcweber avatar Jan 23 '24 15:01 danielcweber

@danielcweber as I mentioned above CI will succeed because the test I implemented succeeds. But, when I use this same code in production (talking to a database) it fails. And I do not know what test to implement to reproduce that. Can you help?

xperiandri avatar Jan 23 '24 19:01 xperiandri

Deserializing generic struct fails on real database

xperiandri avatar Jan 23 '24 19:01 xperiandri

@danielcweber as I mentioned above CI will succeed because the test I implemented succeeds. But, when I use this same code in production (talking to a database) it fails. And I do not know what test to implement to reproduce that. Can you help?

@xperiandri If it cannot be shown to be a bug in Gremlinq, you can always book a paid support session with me and we'll have a look at your setup.

danielcweber avatar Jan 23 '24 19:01 danielcweber

If you can advise me where to write a test I can try myself first

xperiandri avatar Jan 23 '24 20:01 xperiandri

Closing since I have no clue what the issue is here. If it persists, please write some reproduction code.

danielcweber avatar Apr 29 '24 19:04 danielcweber