Captcha
Captcha copied to clipboard
Fork
Hey there, I just released v2 of my fork. I migrated issues & open PRs, added some new features, fixed bugs, added GIF & PNG support, some helper functions & extended its test suite - today I saw your statement in #102 that it's been a long time and I guess you've got many other things on your plate ..
Many thanks for this library, cheers
S1SYPHOS
@S1SYPHOS Do you plan to create a Symfony Bundle for it? We have issues there and get no response. See https://github.com/Gregwar/CaptchaBundle/pull/231
@blankse I didn't plan to, and frankly I don't think I will, since I don't use Symfony myself. I don't know how to properly setup & test such a plugin, and looking at the PRs and issues on the plugin this seems like quite a lot of work ..
I'm sorry, but that's something @Gregwar would have to take care of.
I also forked this to https://github.com/diversen/Captcha It just fixes the issues https://github.com/Gregwar/Captcha/issues/100 Which means that it will work on php8.1 (at least in my use-case)
I did a little more than that 😀
Hello, @S1SYPHOS would you mind reflecting your changes here ? I am sorry I only have little time to maintain this repository, I am ok with other people taking care :slightly_smiling_face:
@Gregwar I can help in a maintenance capacity if you'd like.
@Gregwar Sorry for my late reply, but here goes:
First of all, I fixed #60, #80, #84, #91 and #100 and applied PRs #74, #89, #92, #95 and #101. While doing so, I refactored a lot of code and added full support for PHP8. Most changes are listed below the first v2 beta release, see here.
Later on, I added features like "background noise" (using small random letters), custom fonts and optional support for tesseract-ocr
, hex color support was added as well as docstrings and such, writing virtual files when testing, improved (yet still basic) tests .. and just keeping things as DRY as possible :grin:
If it is still code compatible with the current version (keeps most of BC, especially the Sf bundle), maybe we could change things here directly, would you agree doing that @S1SYPHOS , if I add you to the owners ?
@bytestream are you using the Sf Bundle? Looks like @S1SYPHOS is not using it so maybe we can have another pair of eyes on this matter to keep things compatible :slightly_smiling_face:
@bytestream are you using the Sf Bundle?
I'm afraid not. We use Laravel and are using this package directly.
At this point, it's not even close to being compatible 😀 since I'm not using Symfony (never have tbh), I don't know how to test this even if I helped migrate the bundle 😕
I see, it drifted too much I will try to find a slot to ensure that this is compatible with 8.0 / 8.1 at least (and doesn't break Sf bundle as well)
@Gregwar I think at a minimum you can merge the below to cover PHP 8.0 and 8.1 without breaking anything:
- https://github.com/Gregwar/Captcha/pull/105
- https://github.com/Gregwar/Captcha/pull/106
- https://github.com/Gregwar/Captcha/pull/101
- https://github.com/Gregwar/Captcha/pull/92
@Gregwar Would be great if you could merge the above, that looks like all that is needed at the moment.
@Gregwar do you still want some help with maintenance of this library?
Hello, I am not sure to understand your bullet points:
- and 2) are just workflow/packaging things, how does it prevent PHP from working with PHP8 ?
- is merged already, 4) is fixed
I also tagged v1.2.1
to ensure composer re-packaging